Thread (20 messages) 20 messages, 8 authors, 2012-03-25

Re: [PATCH] ext2: Don't export ext2_mask_flags() to user space

From: Mike Frysinger <hidden>
Date: 2012-03-24 17:59:38
Also in: lkml, stable

On Saturday 24 March 2012 04:37:56 Al Viro wrote:
On Sat, Mar 24, 2012 at 02:50:38AM -0400, Mike Frysinger wrote:
quoted
quoted
and that's it. ??blackfin and do_mounts_rd are doing the same thing
(blackfin - buggy, AFAICS).
buggy how ?  they're not exactly the same as the Blackfin code is
setting things up for the uClinux MTD map.  it isn't parsing the
filesystem itself (ignoring the size extraction from the superblock).
Compare and you'll see...  Block size on ext2 may be bigger than 1Kb;
->s_log_block_size gives the shift (1Kb -> 0, 2Kb -> 1, etc.)  Offset
0x18 in superblock, __le32...
fair enough.  the users of the Blackfin code should generally be OK though due 
to the constrained inputs and runtime systems.
Anyway, I've pushed that into vfs.git#master along with other minor stuff
right now; the last 5 commits in there are handling of ext2 and ext3
headers, starting with "ext2: No longer export ext2_fs.h to user space" by
Thierry Reding, with the next 3 after it doing the move and trimming...
Should propagate to git.kernel.org in a few.
looks good to me
Acked-by: Mike Frysinger <redacted>
-mike

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help