Re: [PATCH 1/2] e2image: truncate raw image file to correct size
From: Phillip Susi <hidden>
Date: 2012-02-17 00:21:23
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/16/2012 06:30 PM, Ted Ts'o wrote:
Sorry, I'm still not understanding what you're concerned about. The last write should seek to the end of the file system, and write a single byte --- which would be past the last hole. The goal is to make sure the file system is large enough that e2fsck doesn't complain about the file system image being apparently too small.
That single byte write doesn't happen when sparse == 0.
I don't understand why you're saying that it's not writing anything beyond the last hole, and why you're saying i_size is not being updated. It's working for me; I can run e2fsck on the generated image, and it's not complaining that the file system is too small.
It works for you because sparse != 0, thus triggering that one byte write. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPPZ2CAAoJEJrBOlT6nu75P30H/1KxTJu1NoFk2Wp/JcUwSkj/ gKq+83ykggPvtcDFcGFECRcIBgFdgPyY7pt08RTrvbSjwGLDGbK1zKOFvpYyHHak yBOC96NTmtLAs1oesCVV+C/zjDehhojeh6xuKCC5EpMoL8KdAdREAWOcsr42fuhj Qr/XKlQX8xFTrvmFQLORAOV1e7hHFQKOs1R29pCudQcppm7ZnlAWKHD7pGz9478U tJjxg2B8YUrGriZFe0oAjotxTTTUIK7vErs+tfNgsYmvSFf0XbyC6V0DSpjbK7rf 9RPHaSukNY9ax2dKwGGQp9jQpRZ+RIp5GoZCOSCEOScOviRvHyfdOCgsqEsOYsk= =9RZA -----END PGP SIGNATURE-----