Re: [PATCH 2/3] ext4: remove unnecessary assignments in xattr.c
From: Ted Ts'o <tytso@mit.edu>
Date: 2012-02-13 23:21:10
From: Ted Ts'o <tytso@mit.edu>
Date: 2012-02-13 23:21:10
On Mon, Nov 07, 2011 at 09:32:03PM +0800, Zheng Liu wrote:
From: Zheng Liu <redacted> In some functions, 'error' variable is assigned but not used when the result of if statement is false. Signed-off-by: Zheng Liu <redacted>
I really wouldn't worry about this. It increases the size of both the source and the binary, and if there are architectures where registers are especially precious, it's easy enough for the compiler to optimize appropriately. - Ted