Re: [PATCH 10/22] ext4: Verify and calculate checksums for extent tree blocks
flat view
From: Darrick J. Wong <hidden>
Date: 2011-12-05 19:50:16
Also in:
linux-fsdevel, lkml
On Mon, Dec 05, 2011 at 11:40:15AM -0500, Ted Ts'o wrote:
On Mon, Nov 28, 2011 at 03:27:25PM -0800, Darrick J. Wong wrote:quoted
/* + * This is the extent tail on-disk structure. + * All other extent structures are 12 bytes long. It turns out that + * block_size % 12 >= 4 for all valid block sizes (1k, 2k, 4k).More generally, block_size % 12 is >= 4 for all powers of 2 greater than 12 bytes. I'd probably remove (1k, 2k, 4k) because that might scare people who might say, "hey! I'm using a 16k block size on my HPC system running on a Power or Itanium box --- am I going to be OK?". Valid block sizes go up to the page size of the hardware in question...
Ok. --D