Thread (5 messages) 5 messages, 3 authors, 2011-11-19
STALE5361d

[PATCH] ext4: remove unneeded variable.

From: Namjae Jeon <hidden>
Date: 2011-11-11 15:02:41
Also in: lkml
Subsystem: ext4 file system, filesystems (vfs and infrastructure), the rest · Maintainers: "Theodore Ts'o", Alexander Viro, Christian Brauner, Linus Torvalds

ret2 is not needed in ext4_flush_completed_IO().

Signed-off-by: Namjae Jeon <redacted>
Signed-off-by: Amit Sahrawat <redacted>
---
 fs/ext4/fsync.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 00a2cb7..40397ac 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -81,7 +81,6 @@ int ext4_flush_completed_IO(struct inode *inode)
 	struct ext4_inode_info *ei = EXT4_I(inode);
 	unsigned long flags;
 	int ret = 0;
-	int ret2 = 0;
 
 	dump_completed_IO(inode);
 	spin_lock_irqsave(&ei->i_completed_io_lock, flags);
@@ -105,12 +104,10 @@ int ext4_flush_completed_IO(struct inode *inode)
 		 */
 		spin_unlock_irqrestore(&ei->i_completed_io_lock, flags);
 		ret = ext4_end_io_nolock(io);
-		if (ret < 0)
-			ret2 = ret;
 		spin_lock_irqsave(&ei->i_completed_io_lock, flags);
 	}
 	spin_unlock_irqrestore(&ei->i_completed_io_lock, flags);
-	return (ret2 < 0) ? ret2 : 0;
+	return (ret < 0) ? ret : 0;
 }
 
 /*
-- 
1.7.4.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help