Thread (2 messages) 2 messages, 2 authors, 2011-12-29
STALE5267d

[PATCH 2/2] [PATCH] ext4: avoid calculating free inodes twice in find_group_orlov()

From: Zheng Liu <hidden>
Date: 2011-11-17 07:18:44
Subsystem: ext4 file system, filesystems (vfs and infrastructure), the rest · Maintainers: "Theodore Ts'o", Alexander Viro, Christian Brauner, Linus Torvalds

ext4_free_inodes_count() shouldn't be called twice in here

Signed-off-by: Zheng Liu <redacted>
---
 fs/ext4/ialloc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 00beb4f..1d81bfc 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -477,8 +477,7 @@ fallback_retry:
 	for (i = 0; i < ngroups; i++) {
 		grp = (parent_group + i) % ngroups;
 		desc = ext4_get_group_desc(sb, grp, NULL);
-		if (desc && ext4_free_inodes_count(sb, desc) &&
-		    ext4_free_inodes_count(sb, desc) >= avefreei) {
+		if (desc && ext4_free_inodes_count(sb, desc) >= avefreei) {
 			*group = grp;
 			return 0;
 		}
-- 
1.7.4.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help