On Sun, 2011-09-18 at 18:54 +0400, Dmitry Monakhov wrote:
Add two new operations:
- getattr: ioctl(fd, EXT2_IOC_GETFLAGS, &fl)
- setattr: ioctl(fd, EXT2_IOC_SETFLAGS, &random_flags)
By default IOC_SET_SETFLAGS has zero probability because
it may produce inodes with APPEND or IMMUTABLE flags which
are not deletable by default. Let's assumes that one who
enable it knows how to delete such inodes.
For example like follows:
find $TEST_PATH -exec chattr -i -a {} \;
rm -rf $TEST_PATH
Signed-off-by: Dmitry Monakhov <redacted>
I have a question below. I think this is probably
a good addition, though it should be made so it
works for more than EXTx.
If I understand the way it would be used, this will
simply be another operation that gets randomly performed
by fsstress while it operates, right?
I have not done any testing with this yet.
Reviewed-by: Alex Elder <redacted>
. . .
quoted hunk ↗ jump to hunk
@@ -1729,6 +1738,58 @@ setxattr_f(int opno, long r)
}
void
+getattr_f(int opno, long r)
+{
+#ifdef HAVE_EXT2_INCLUDE
+ int fd;
+ int e;
+ pathname_t f;
+ uint fl;
+ int v;
+
+ init_pathname(&f);
+ if (!get_fname(FT_ANYm, r, &f, NULL, NULL, &v))
+ append_pathname(&f, ".");
I don't understand the purpose of appending a "." to the
end of the path. Do you intend to just use "." if
no other file matches? (That may not be a good thing to
do--it might not be testing the intended target.)
Or are you intending to append "/." so for a directory
its "." link gets used in the open? If so that's not
what this does (it simply makes "a/b/x" become "a/b/x.").
Same comments apply to setattr_f().
quoted hunk ↗ jump to hunk
+ fd = open_path(&f, O_RDWR);
+ e = fd < 0 ? errno : 0;
+ check_cwd();
+
+ e = ioctl(fd, EXT2_IOC_GETFLAGS, &fl);
+ if (v)
+ printf("%d/%d: getattr %s %u %d\n", procid, opno, f.path, fl, e);
+ free_pathname(&f);
+ close(fd);
+#endif
+}
+
+void
+setattr_f(int opno, long r)
+{