Thread (8 messages) 8 messages, 3 authors, 2011-10-04

Re: [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2011-10-04 06:59:53
Also in: linux-crypto, linux-fsdevel, lkml

On Mon, Oct 03, 2011 at 05:55:10PM -0700, Darrick J. Wong wrote:
So what I think I'm hearing is...

1. Apply Bob's slice-by-8 algorithm patch to regular crc32.
2. Adapt crc32's build code to generate crc32c as well.
3. Remove crypto/crc32c.c's implementation and have it wrap the code generated
   by #2.
4. Retain the current libcrc32c.  I guess if you don't configure CRYPTO and
   CRYPTO_CRC32C then it could also just reference the generated crc32c functions
   directly.

Is this a satisfactory way to move forward?
All good except that you don't really have to touch libcrc32c
at all.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help