Re: [PATCH 03/28] ext4: ext4_mkdir should dirty dir_block with the parent inode
From: Tao Ma <hidden>
Date: 2011-10-18 04:11:54
Hi Darrick, On 10/08/2011 03:54 PM, Darrick J. Wong wrote:
ext4_mkdir calls ext4_handle_dirty_metadata with dir_block and the inode "dir". Unfortunately, dir_block belongs to the newly created directory (which is "inode"), not the parent directory (which is "dir"). Fix the incorrect association.
could you please re-send this patch and other fixes that isn't related to metadata checksum? I need this when implementing inlined dir, and I guess this can be merged in this merge window. Thanks Tao
quoted hunk ↗ jump to hunk
Signed-off-by: Darrick J. Wong <redacted> --- fs/ext4/namei.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 6d3fab4..50c7294 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c@@ -1863,7 +1863,7 @@ retry: ext4_set_de_type(dir->i_sb, de, S_IFDIR); inode->i_nlink = 2; BUFFER_TRACE(dir_block, "call ext4_handle_dirty_metadata"); - err = ext4_handle_dirty_metadata(handle, dir, dir_block); + err = ext4_handle_dirty_metadata(handle, inode, dir_block); if (err) goto out_clear_inode; err = ext4_mark_inode_dirty(handle, inode); --To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html