Thread (4 messages) 4 messages, 3 authors, 2011-10-10

Re: [PATCH] ext3: Remove the obsolete broken EXT3_IOC32_WAIT_FOR_READONLY.

From: Jan Kara <jack@suse.cz>
Date: 2011-10-10 16:27:02

On Sat 08-10-11 16:52:35, Ted Tso wrote:
On Sat, Oct 08, 2011 at 12:12:33AM +0200, Jan Kara wrote:
quoted
On Fri 07-10-11 23:21:18, Tao Ma wrote:
quoted
From: Tao Ma <redacted>

There are no user of EXT3_IOC32_WAIT_FOR_READONLY and also it is
broken. No one set the set_ro_timer, no one wake up us and our
state is set to TASK_INTERRUPTIBLE not RUNNING. So remove it.
  Hmm, I vaguely recall Andrew had some debugging patches which were using
turn_ro_timer and this functionality. But I'm not sure if they are still
usable or if they still make sense when one can easily test crashing using
virtual machines... Andrew?
That's why I decided to accept the corresponding patch for ext4; if
the rest of debugging patch is out-of-tree, then might as well have it
all out-of-tree --- and killall qemu is probably a better way of
testing this anyway.
  OK. I've merged the patch in my tree. If Andrew shouts loudly, I can
always revert it :)

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help