Thread (3 messages) 3 messages, 2 authors, 2011-09-05

Re: [PATCH] ext4: Fix a possible corruption in dx_probe.

From: Tao Ma <hidden>
Date: 2011-09-05 02:17:56

On 09/04/2011 09:57 PM, Ted Ts'o wrote:
On Thu, Sep 01, 2011 at 12:00:52AM +0800, Tao Ma wrote:
quoted
From: Tao Ma <redacted>

For all the callers of dx_probe, frame_in is passed in uninitialized.
So we should set frame->bh to NULL in the beginning of while, not
the end. Otherwise, the first "goto fail2" will try to brelse(frame->bh)
while frame->bh is still invalid.
There's a "frame->bh = NULL" statement at the very beginning of
dx_probe().   Shouldn't that do the trick?
Oh, sorry for the false alarm.

Thanks
Tao
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help