Thread (3 messages) 3 messages, 2 authors, 2011-08-29

Re: [PATCH] xfstests: don't print "do not support" warnings unless verbose is specified

From: Dave Chinner <david@fromorbit.com>
Date: 2011-08-29 05:52:00
Also in: linux-xfs

On Sat, Aug 27, 2011 at 01:43:22PM -0400, Theodore Ts'o wrote:
Commit 630421f6d449 attempts to avoid printing the "fallocate not
supported" warning if the -q (quiet) option is specified on the
command-line.  Unfortunately tests 75 and 112 don't set the -q flag.
This causes test failures for file systems that don't support
fallocate or the punch hole functionality.

I considered changing tests 75 and 112 to pass -q to fsx, but that
would suppress other warning messages that could be legitimate test
failures, so I decided to add a new -v (vebose) flag.
Oh, so now we can have verbose quietness? Or is it quiet verbosity?
That quickly leads to insanity.... :/

The quiet flag only suppresses output that is otherwise logged and
output when a failure occurs. Hence setting the quiet won't cause
any loss of functionality or error detection for these tests so you
should just add the quiet flag to the tests.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help