Thread (6 messages) 6 messages, 4 authors, 2011-08-19

Re: xfstests #62 broken on ext4

From: Christoph Hellwig <hch@infradead.org>
Date: 2011-08-13 20:14:27
Also in: linux-xfs

On Sat, Aug 13, 2011 at 10:38:51AM -0400, Theodore Ts'o wrote:
Xfstests #62 was recently enabled by commit b2b36d0a4.

However, this test is failing for ext4 because ext4 doesn't support
extended attributes on anything other than regular files and
directories.  This is behavior is documented in the attr(5) man page:
As explained to you before that is not the reason why it fails.  The
reason is that Andreas Gruenbacher changed return values for certain
xattr operations in commit 55b23bde19c08f14127a27d461a4e079942c7258.

It looks like XFS is not conformant to documented behaviour and the file
system generic code.
Care to explain that conclusion?  A simple test and/or a look at the
code will reveal that this is not true.

Below is the patch from Andreas that makes the test work properly again
on Linux 3.0+ on XFS, although other filesystem still have some issues
with it.  For ext4 that mostly seems the presence of the lost+found
directory, and a different ordering from readdir than expected.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help