Re: [PATCH v2] ext4: Deprecate data=journal mount option
From: Lukas Czerner <hidden>
Date: 2011-08-11 15:02:01
On Tue, 28 Jun 2011, Lukas Czerner wrote:
Data journalling mode (data=journal) is known to be neglected by developers and only minority of people is actually using it. This mode is also less tested than the other two modes by the developers. This creates a dangerous combination, because the option which seems *safer* is actually less safe the others. So this commit adds a warning message in case that data=journal mode is used, so the user is informed that the mode might be removed in the future.
Any comments on this ? Is that feasible to remove is someday ? Thanks! -Lukas
quoted hunk ↗ jump to hunk
Signed-off-by: Lukas Czerner <redacted> --- fs/ext4/super.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9ea71aa..9d189cf 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c@@ -1631,6 +1631,11 @@ static int parse_options(char *options, struct super_block *sb, sbi->s_min_batch_time = option; break; case Opt_data_journal: + ext4_msg(sb, KERN_WARNING, + "Using data=journal may be removed in the " + "future. Please, contact " + "linux-ext4@vger.kernel.org if you are " + "using this feature."); data_opt = EXT4_MOUNT_JOURNAL_DATA; goto datacheck; case Opt_data_ordered: