Thread (10 messages) 10 messages, 5 authors, 2011-07-14

Re: [PATCH 1/2] ext3: make ext3 mount default to barrier=1

flat view

From: Chris Mason <hidden>
Date: 2011-07-12 13:24:47
Also in: linux-fsdevel

Excerpts from Christoph Hellwig's message of 2011-07-11 14:25:59 -0400:
From: Chris Mason <redacted>
Thanks for digging this out, you can toss in a sob for me.  Probably
best to give yourself credit in the from:, since you went to all the
trouble of diving in the vendor kernels.

Then again, if you're using the old email to try and throw Andrew off
our trail, go for it.

-chris
quoted hunk ↗ jump to hunk
This patch turns on barriers by default for ext3.  mount -o barrier=0
will turn them off.

Acked-by: Jeff Mahoney <redacted>

Index: linux-2.6/fs/ext3/super.c
===================================================================
--- linux-2.6.orig/fs/ext3/super.c    2011-06-30 21:19:37.389544975 +0200
+++ linux-2.6/fs/ext3/super.c    2011-07-02 13:56:51.877784292 +0200
@@ -1718,6 +1718,8 @@ static int ext3_fill_super (struct super
     sbi->s_resuid = le16_to_cpu(es->s_def_resuid);
     sbi->s_resgid = le16_to_cpu(es->s_def_resgid);
 
+    /* enable barriers by default */
+    set_opt(sbi->s_mount_opt, BARRIER);
     set_opt(sbi->s_mount_opt, RESERVATION);
 
     if (!parse_options ((char *) data, sb, &journal_inum, &journal_devnum,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help