Thread (4 messages) 4 messages, 2 authors, 2011-07-11

Re: [PATCH] ext4: Fix a double free of sbi->s_group_info in ext4_mb_init_backend

From: Ted Ts'o <tytso@mit.edu>
Date: 2011-07-11 22:44:12

On Mon, Jul 11, 2011 at 11:26:56PM +0800, Tao Ma wrote:
From: Tao Ma <redacted>

If we meet with an error in ext4_mb_add_groupinfo, we kfree
sbi->s_group_info[group >> EXT4_DESC_PER_BLOCK_BITS(sb)], but fail to
reset it to NULL. So the caller ext4_mb_init_backend will try to kfree
it again and causes a double free. So fix it by resetting it to NULL.

Some typo in comments of mballoc.c are also changed.

Signed-off-by: Tao Ma <redacted>
Added to the ext4 tree, thanks.

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help