On Mon, Jun 27, 2011 at 10:17:12PM -0700, Allison Henderson wrote:

On 06/27/2011 09:59 PM, Dave Chinner wrote:

quoted

On Mon, Jun 27, 2011 at 09:27:25PM -0700, Allison Henderson wrote:
I seriously dislike conditional parameter passing in shell scripts
at the best of times, but for filter functions I really think it is
the wrong thing to do. It significantly obfuscates the working of
the function for no really good reason.

Just write a new filter function, and factor out the common parts of
them if the amount of code duplication is sufficient to make it
desirable to do so.

Ok, it doesn't look like a lot of code, I can separate them into their
own functions.

quoted

quoted

+	md5sum $testfile | cut -d ' ' -f1

Why cut out the file name? It's not like it changes at all....

Oh, it looked like there's a pid attached to the file name, so I
thought I should remove that from the output

Oh, it does too. My mistake, too trigger happy, just looking for
ways to keep things relatively simple. Maybe using a wrapper
function so if we ever need to modify it we only need to change one
line of code would acheive the same thing?

Cheers,

Dave.

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs