Thread (25 messages) 25 messages, 6 authors, 2011-07-01

Re: [PATCH 4/8] fs: kill i_alloc_sem

From: Christoph Hellwig <hch@infradead.org>
Date: 2011-06-20 22:18:57
Also in: linux-btrfs, linux-fsdevel

On Mon, Jun 20, 2011 at 02:32:03PM -0700, Joel Becker wrote:
	Are we guaranteed that all allocation changes are locked out by
i_dio_count>0?  I don't think we are.  The ocfs2 code very strongly
assumes the state of a file's allocation when it holds i_alloc_sem.  I
feel like we lose that here. 
You aren't, neither with the old i_alloc_sem code, nor with the 1:1
replacement using i_dio_count.

Do a quick grep who gets i_alloc_sem exclusively (down_write): it's
really just the truncate code, and it's cut & paste duplicates in ntfs
and reiserfs.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help