Re: [PATCH 1/3] fs: Create __block_page_mkwrite() helper passing error values back
From: Christoph Hellwig <hch@infradead.org>
Date: 2011-05-18 18:07:37
Also in:
linux-fsdevel
From: Christoph Hellwig <hch@infradead.org>
Date: 2011-05-18 18:07:37
Also in:
linux-fsdevel
On Wed, May 18, 2011 at 05:18:00PM +0200, Jan Kara wrote:
Create __block_page_mkwrite() helper which does all what block_page_mkwrite() does except that it passes back errors from __block_write_begin / block_commit_write calls.
Looks good to me. Long term I wonder wether we should force ->page_mkwrite to always return the page locked and just use normal errnos all the way up to do_wp_page, but that can be left for a later iteration as it would be quite invasive. Reviewed-by: Christoph Hellwig <hch@lst.de>