On Mon, Feb 7, 2011 at 3:31 PM, Manish Katiyar [off-list ref] wrote:

On Mon, Feb 7, 2011 at 3:23 PM, Ted Ts'o [off-list ref] wrote:

quoted

On Sat, Jan 29, 2011 at 09:40:34PM -0800, Manish Katiyar wrote:

quoted

Any feedback on this ?

The patch looks good, but it doesn't fix bug #26752.

The root cause of that bug is the fact that ext4_sync_fs() and
ext4_put_super() assumes that sbi has been initialized.

Hi Ted,

Is there anything else that I need to do to get this merged in your tree ?

Hmm.. Actually I was looking at generic_super_shutdown() which I
thought would call ext4_put_super() only if sb->root is set, and since
I was setting sb->root explicitly to NULL in my patch in case of
failures.

--
Thanks -
Manish

-- 
Thanks -
Manish