Re: [PATCH V3 RESEND 2] ext4: serialize unaligned asynchronous DIO
From: Ted Ts'o <tytso@mit.edu>
Date: 2011-02-07 02:33:49
From: Ted Ts'o <tytso@mit.edu>
Date: 2011-02-07 02:33:49
On Fri, Jan 21, 2011 at 12:26:54PM -0600, Eric Sandeen wrote:
ext4 has a data corruption case when doing non-block-aligned asynchronous direct IO into a sparse file, as demonstrated by xfstest 240.
Hey Eric, One question about this patch. You are currently using a hashed array of size 37 for the waitqueue; what about using a similarly sized hashed array for the aio_mutex? We only take it for unaligned mutexes, and I'm trying to work on reducing the size of ext4 inode, since it gets rather large in the inode cache.... - Ted