Re: [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully.
From: Joel Becker <jlbec@evilplan.org>
Date: 2011-01-24 17:20:42
On Mon, Jan 24, 2011 at 02:31:43PM +0100, Jan Kara wrote:
On Sat 22-01-11 22:29:01, Joel Becker wrote:quoted
This API is markedly better to read. Btw, does _nofail() mean no possible failures, or just no memory errors? If it is no failures, I'd love to see the function become void.jbd2_journal_start can always fail e.g. because the journal is aborted. So it really just means no memory failures...
Then _nofail() is a terrible name, because it can still fail. Let's call it jbd2_journal_start_nofs(); that's what it is. Joel -- "Under capitalism, man exploits man. Under Communism, it's just the opposite." - John Kenneth Galbraith http://www.jlbec.org/ jlbec@evilplan.org