Thread (5 messages) 5 messages, 4 authors, 2009-01-15

Re: [PATCH] ext2/3/4: change i_mutex usage on lseek

From: Jamie Lokier <hidden>
Date: 2009-01-15 13:02:09
Also in: linux-fsdevel

Dave Kleikamp wrote:
Is there any reason you couldn't have just changed generic_file_llseek()
to do this rather than making identical changes to the individual file
systems.  I would think this optimization would be safe for any file
system.
Is it safe on 32-bit systems where 64-bit updates are not atomic?

You may say that doing multiple parallel lseek() calls is undefined
behaviour, so it's ok to end up with file position that none of the
individual lseek() calls asked for.

But if it's undefined behaviour, no programs should be doing parallel
lseek() calls on the same open file, so why optimise it at all?

-- Jamie
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help