Thread (13 messages) 13 messages, 6 authors, 2008-10-16

Re: [PATCH updated] ext4: Fix file fragmentation during large file write.

From: Theodore Tso <tytso@mit.edu>
Date: 2008-10-16 02:41:41
Also in: linux-mm

On Wed, Oct 15, 2008 at 07:51:32PM -0400, Chris Mason wrote:
Just FYI, I ran this with compilebench -i 20 --makej and my log is full
of these:

ext4_da_writepages: jbd2_start: 1024 pages, ino 520417; err -30
Pid: 4072, comm: pdflush Not tainted 2.6.27 #2
That's from ext4_journal_start_sb:

       if (sb->s_flags & MS_RDONLY)
       	  return ERR_PTR(-EROFS);

What was the very first error in your log?  It looks like ext4 somehow
flagged some kind of filesystem error or aborted the journal due to
some failure, and log gets filled these messages.  We should probably 
should throttle these messages by simply putting a

       if (sb->s_flags & MS_RDONLY)
		return -ERNOFS;

at the beginning of ext4_da_writepages() so we don't fill the logs
with extraneous messages that obscure more important error messages.

     			      	      	   	     - Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help