Re: [PATCH 1/4] vfs: vfs-level fiemap interface
From: Andreas Dilger <hidden>
Date: 2008-09-16 06:51:26
Also in:
linux-fsdevel
From: Andreas Dilger <hidden>
Date: 2008-09-16 06:51:26
Also in:
linux-fsdevel
On Sep 15, 2008 10:53 -0700, Mark Fasheh wrote:
On Mon, Sep 15, 2008 at 10:49:48AM -0400, Christoph Hellwig wrote:quoted
I agree to you (or someone elses - don't remember anymore) suggestion to put in more padding so we can add fields later. I strongly disagree putting in features now that we neither have a user, nor a usecase or testcase for.So, how about another 64 bits of padding in struct fiemap_extent? That could help cover future uses like compression, which might require another 64 bit offset field - we only have 32 bits of reserved space there right now.
I'd be happy to see it. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.