Re: [PATCH 3/4] ext2: Avoid printk floods in the face of directory corruption
From: Eugene Teo <hidden>
Date: 2008-09-18 09:47:14
Also in:
lkml
From: Eugene Teo <hidden>
Date: 2008-09-18 09:47:14
Also in:
lkml
On Sat, Sep 13, 2008 at 11:32 PM, Theodore Ts'o [off-list ref] wrote: [...]
Eend:
- p = (ext2_dirent *)(kaddr + offs);
- ext2_error (sb, "ext2_check_page",
- "entry in directory #%lu spans the page boundary"
- "offset=%lu, inode=%lu",
- dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs,
- (unsigned long) le32_to_cpu(p->inode));
+ if (!quiet) {
+ p = (ext2_dirent *)(kaddr + offs);
+ ext2_error (sb, "ext2_check_page",^^^^^^^^^^^^^^^^^^
+ "entry in directory #%lu spans the page boundary" + "offset=%lu, inode=%lu", + dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs, + (unsigned long) le32_to_cpu(p->inode));
Minor issue. Since you are already changing "ext2_check_page" to __func__, you might as well change it here too. Thanks, Eugene