Thread (13 messages) 13 messages, 5 authors, 2008-10-01

Re: [PATCH 3/4] ext2: Avoid printk floods in the face of directory corruption

From: Eugene Teo <hidden>
Date: 2008-09-18 09:47:14
Also in: lkml

On Sat, Sep 13, 2008 at 11:32 PM, Theodore Ts'o [off-list ref] wrote:
[...]
 Eend:
-       p = (ext2_dirent *)(kaddr + offs);
-       ext2_error (sb, "ext2_check_page",
-               "entry in directory #%lu spans the page boundary"
-               "offset=%lu, inode=%lu",
-               dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs,
-               (unsigned long) le32_to_cpu(p->inode));
+       if (!quiet) {
+               p = (ext2_dirent *)(kaddr + offs);
+               ext2_error (sb, "ext2_check_page",
                                                ^^^^^^^^^^^^^^^^^^
+                       "entry in directory #%lu spans the page boundary"
+                       "offset=%lu, inode=%lu",
+                       dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs,
+                       (unsigned long) le32_to_cpu(p->inode));
Minor issue. Since you are already changing "ext2_check_page" to
__func__, you might as well change it here too.

Thanks, Eugene
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help