Thread (15 messages) 15 messages, 8 authors, 2008-07-09

Re: [PATCH 3/3] Add timeout feature

From: Dave Chinner <david@fromorbit.com>
Date: 2008-07-08 23:10:27
Also in: dm-devel, linux-fsdevel, linux-xfs, lkml

On Mon, Jul 07, 2008 at 01:07:31PM +0200, Pavel Machek wrote:
Hi!
quoted
I still disagree with this whole patch.  There is not reason to let
the freeze request timeout - an auto-unfreezing will only confuse the
hell out of the caller.  The only reason where the current XFS freeze
call can hang and this would be theoretically useful is when the
What happens when someone dirties so much data that vm swaps out
whatever process that frozen the filesystem?
a) you can't dirty a frozen filesystem - by definition a frozen
   filesystem is a *clean filesystem* and *cannot be dirtied*.
b) Swap doesn't write through the filesystem
c) you can still read from a frozen filesystem to page your
   executableѕ in.
d) if dirtying another unfrozen filesystem swaps out your
   application so it can't run, then there's a major VM bug.
   Regardless, until the app completes it is relying on the
   filesystem being frozen, so it better remain frozen....
I though that was why the timeout was there...
Not that I know of. 

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help