Thread (44 messages) 44 messages, 7 authors, 2008-06-17

Re: What's cooking in e2fsprogs.git (topics)

From: Jose R. Santos <hidden>
Date: 2008-03-05 17:00:05

On Fri, 29 Feb 2008 10:43:33 -0500
Theodore Tso [off-list ref] wrote:
Block bitmap differences:  +8195Group 3 block(s) in use but group is marked BLO
CK_UNINIT
Fix? yes

	This mangling is happening because error reporting for
	PR_5_INODE_UNINIT is getting intermingled with the
	PR_5_INODE_USED/PR_5_INODE_UNUSED reporting, which isn't a
	good idea.  The comment around the code says:

		/* 
		 * We should never hit this, because it means that
		 * inodes were marked in use that weren't noticed
		 * in pass1 or pass 2. It is easier to fix the problem
		 * than to kill e2fsck and leave the user stuck.
		 */

	So I'm guessing there's something else wrong going on here....
After looking at the misc/mke2fs.c a second time, I notice that there
is one chunk missing in setup_lazy_bg from the 6270612c commit:

+
+                       /* Skip groups with GDT backups because the resize
+                        * inode has blocks allocated in them, and the last
+                        * group because it needs block bitmap padding. */
+                       if ((ext2fs_bg_has_super(fs, i) &&
+                            sb->s_reserved_gdt_blocks) ||
+                           i == fs->group_desc_count - 1)
+                               continue;
+

This should fix the problem you see above.  Now, I wonder if you would
see a similar problem if the filesystems is created with the meta_bg
option since we don't check to see if the block groups has a bgd.

-JRS
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help