Thread (6 messages) 6 messages, 2 authors, 2008-02-19

Re: How were some of the lustre e2fsprogs test cases generated?

From: Theodore Tso <tytso@mit.edu>
Date: 2008-02-19 00:36:46

On Mon, Feb 18, 2008 at 07:06:58PM -0500, Theodore Ts'o wrote:
The clusterfs e2fsprogs code doesn't notice this, because it apparently
ignores ee_start_hi field entirely.  
One minor correction --- the clusterfs e2fsprogs extents code checks
to see if the ee_leaf_hi field is non-zero, and complains if so.
However, it ignores the ee_start_hi field for interior (non-leaf)
nodes in the extent tree, and a number of tests do have non-zero
ee_start_hi fields which cause my version of e2fsprogs to (rightly)
complain.

If you fix this, a whole bunch of tests will fail as a result, and not
exercise the code paths that the tests were apparently trying to
exercise.  Which is what is causing me a bit of worry and wonder about
how those test cases were originally generated....

Regards,

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help