Re: [PATCH] JBD slab cleanups
From: Andreas Dilger <hidden>
Date: 2007-09-19 19:48:13
Also in:
linux-fsdevel, lkml
On Sep 19, 2007 12:15 -0700, Mingming Cao wrote:
quoted hunk ↗ jump to hunk
@@ -96,8 +96,7 @@ static int start_this_handle(journal_t * alloc_transaction: if (!journal->j_running_transaction) { - new_transaction = kmalloc(sizeof(*new_transaction), - GFP_NOFS|__GFP_NOFAIL); + new_transaction = kmalloc(sizeof(*new_transaction), GFP_NOFS);
This should probably be a __GFP_NOFAIL if we are trying to start a new handle in truncate, as there is no way to propagate an error to the caller. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.