Thread (8 messages) 8 messages, 2 authors, 2007-08-10

Re: [PATCH] dir_index: error out instead of BUG on corrupt hash dir limit

From: Eric Sandeen <hidden>
Date: 2007-08-10 16:08:05

Andreas Dilger wrote:
On Aug 09, 2007  17:41 -0500, Eric Sandeen wrote:
quoted
Eric Sandeen wrote:
quoted
A corrupt ondisk hash dir limit will trip an assert in dx_probe,
which calls BUG().  Instead, we can just issue the warning and
fail dx_probe like the other 3 tests just before it.  Thanks
to aviro for suggesting this...  
BTW this type of corruption is apparently quite easily generated by
using the binary windows-only ext driver at www.fs-driver.org....
I'd like to see the actual corruption, to find out why the hash-type
check didn't find it.  If it is because LDISKFS_DX_HASH_LEGACY hash
type is zero, I think we can disable that hash type, and people will
just have to run "e2fsck -fD" to reindex to a new type.  This hasn't
been on for a long, long time.
So far I haven't been able to find it in any of the images provided.

We may have to dual-boot windows & run the crummy driver for a while to
track it down, if we care enough.

Which reminds me, what do you think of the wording in the ext3_warning I
added - is "corruption" appropriate?  The other warnings aren't quite so
stark... hmm maybe we should  add "have you been running a binary-only
driver for windows?"  :)

-Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help