Thread (14 messages) 14 messages, 5 authors, 2007-07-11

Re: [PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc

From: Amit K. Arora <hidden>
Date: 2007-07-11 08:11:41
Also in: linux-fsdevel, linux-xfs, lkml

On Wed, Jul 11, 2007 at 12:10:34PM +1000, Stephen Rothwell wrote:
On Wed, 11 Jul 2007 01:50:00 +0530 "Amit K. Arora" [off-list ref] wrote:
quoted
--- linux-2.6.22.orig/arch/x86_64/ia32/sys_ia32.c
+++ linux-2.6.22/arch/x86_64/ia32/sys_ia32.c
@@ -879,3 +879,11 @@ asmlinkage long sys32_fadvise64(int fd, 
 	return sys_fadvise64_64(fd, ((u64)offset_hi << 32) | offset_lo,
 				len, advice);
 }
+
+asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_lo,
+				unsigned offset_hi, unsigned len_lo,
+				unsigned len_hi)
Please call this compat_sys_fallocate in line with the powerpc version -
it gives us a hint that maybe we should think about how to consolidate
them.  I know other stuff in that file is called sys32_ ... but it is time
for a change :-)
I think this can be handled as a separate patch once this patchset
is in mainline. Since, anyhow we will need to do this for other sys32_
calls which are already there...

--
Regards,
Amit Arora
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help