On Tue, Jul 10, 2007 at 11:21:49PM -0400, Cédric Augonnet wrote:

2007/7/10, Andrew Morton [off-list ref]:

Hi all,

quoted

quoted

+     size = sizeof(struct transaction_stats_s);
+     s->stats = kmalloc(size, GFP_KERNEL);
+     if (s == NULL) {

	       ^

quoted

quoted

+             kfree(s);
+             return -EIO;

ENOMEM

That, and

	if (s->stats == NULL)
		kfree(s);

I'm sorry if i missed some point, but i just don't see the use of such
a kfree here, not sure Andrew meant you should only return ENOMEM
instead, but why issuing those kfree(NULL), instead of just a if (!s)
return ENOMEM ?

kfree() is correct, check isn't.