Thread (11 messages) 11 messages, 3 authors, 2007-07-18

Re: [PATCH] Endianness bugs in e2fsck

From: Theodore Tso <tytso@mit.edu>
Date: 2007-06-23 00:36:51

On Wed, Jun 20, 2007 at 03:03:08PM +0530, Kalpak Shah wrote:
In ext2fs_swap_inode_full() only the first (GOOD_OLD_INODE_SIZE +
i_extra_isize)bytes are copied into inode. The rest of the inode is
not zeroed. So memset the inode to zero if swapfs is enabled. 
This was due to the bug where we weren't dealing with the i_extra_size
correctly, right?  ext2fs_swap_inode_full *should* be swapping the
extra fields and copying it into the inode.  If not, that's should be
the real bug, and adding the memset(inode, 0, bufset) doesn't seem to
be useful.

Am I missing something?

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help