Re: [PATCH 02/23] scripts/mksysmap: fix escape of '$' in the __pi_ pattern

On Wed, Sep 09, 2026 at 09:19:12PM -0700, Nathan Chancellor wrote:

quoted

Commit b18b047002b7 ("kbuild: change scripts/mksysmap into sed script")
converted scripts/mksysmap from a shell script to a sed script.

However an error was made - escaping of '$' required \\ escaping in shell
but only \ in a sed script.

This was mostly corrected in commit 7a6c355b55c0 ("scripts/mksysmap: Fix
escape chars '$'"), but this fix missed arm64 PIE namespace local symbols
like __pi_$x and __pi_$d which appear in System.mapand /proc/kallsyms:

$ grep __pi_\\$ /proc/kallsyms | sort -u
0000000000000000 d __pi_$d
0000000000000000 t __pi_$x

Fix the escaping properly.

Fixes: b18b047002b7 ("kbuild: change scripts/mksysmap into sed script")

No measurable change in build time.

Same comments as before.

Yeah sorry same screw up!

quoted

Assisted-by: LLM
Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

Same thing, is this worth taking to stable? Truthfully, you could

Ack I think it's probably worth it yes like patch 1.

probably send these two changes separately from the series so that we
could send them to Linus with the other pending Kbuild fixes, unless
there are objections from Linus or Nicolas on taking that route? Shaving
two patches off of an ~20 patch series is a 10% reduction so seems worth
it?

Patch 8 relies on 1 + 2, so as long as that ordering was enforced then that's
OK.

I mean if these go as hotfixes then we naturally get that ordering of cousre!

I'll review some of the other low hanging fruit now so that we can start
chunking this series out, since I too care deeply about build times.

Thanks!

--
Cheers,
Nathan

--
Cheers, Lorenzo