[RESEND] Re: [PATCH] Revert "efi/random: Treat EFI_RNG_PROTOCOL output as bootloader randomness"
From: Ivan T. Ivanov <hidden>
Date: 2021-10-13 07:31:03
Also in:
lkml
From: Ivan T. Ivanov <hidden>
Date: 2021-10-13 07:31:03
Also in:
lkml
Hi, Quoting Dominik Brodowski (2021-10-12 11:40:34)
Am Tue, Oct 12, 2021 at 11:27:08AM +0300 schrieb Ivan T. Ivanov:quoted
This reverts commit 18b915ac6b0ac5ba7ded03156860f60a9f16df2b. When CONFIG_RANDOM_TRUST_BOOTLOADER is enabled add_bootloader_randomness() calls add_hwgenerator_randomness() which might sleep,Wouldn't it be better to fix add_bootloader_randomness(), considering that calls to that function are likely to happen quite early during kernel initialization? Especially as it seems to have worked beforehand?
I have tried. I made wait_event_interruptible() optional, but then crng_reseed() segfault badly. And I don't think crng_reseed() is something that I could fix easily. Suggestions are welcomed ;-) Regards, Ivan