Thread (4 messages) 4 messages, 3 authors, 2021-03-07

Re: [PATCH] efi/apple-properties: Handle device properties with software node API

From: Ard Biesheuvel <ardb@kernel.org>
Date: 2021-03-04 08:31:26
Also in: lkml

(+ Lukas)

On Thu, 4 Mar 2021 at 09:28, Heikki Krogerus
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
The old device property API is going to be removed.
Replacing the device_add_properties() call with the software
node API equivalent, device_create_managed_software_node().

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/firmware/efi/apple-properties.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/apple-properties.c b/drivers/firmware/efi/apple-properties.c
index e1926483ae2fd..4c3201e290e29 100644
--- a/drivers/firmware/efi/apple-properties.c
+++ b/drivers/firmware/efi/apple-properties.c
@@ -157,7 +157,7 @@ static int __init unmarshal_devices(struct properties_header *properties)
                if (!entry[0].name)
                        goto skip_device;

-               ret = device_add_properties(dev, entry); /* makes deep copy */
+               ret = device_create_managed_software_node(dev, entry, NULL);
                if (ret)
                        dev_err(dev, "error %d assigning properties\n", ret);

--
2.30.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help