On Thu, Aug 20, 2015 at 04:07:06PM +0100, Matt Fleming wrote:

On Tue, 11 Aug, at 02:16:27PM, Lee, Chun-Yi wrote:

quoted

Moved the function of transferring EFI status to kernel error for
later used by EFI stub.

 
Might I suggest:

 "Move the function for converting EFI status to kernel error values
  from drivers/firmware/efi/ to include/linux/efi.h for use by the x86
  EFI stub in an upcoming patch."

?

Thanks for your suggestion, I will follow it.

quoted

Reviewed-by: Jiri Kosina <jkosina-IBi9RG/b67k@public.gmane.org>
Tested-by: Jiri Kosina <jkosina-IBi9RG/b67k@public.gmane.org>
Signed-off-by: Lee, Chun-Yi <jlee-IBi9RG/b67k@public.gmane.org>
---
 drivers/firmware/efi/vars.c | 33 ---------------------------------
 include/linux/efi.h         | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+), 33 deletions(-)

The patch content is fine,

Reviewed-by: Matt Fleming <redacted>

Thanks

-- 
Matt Fleming, Intel Open Source Technology Center

Joey Lee