Re: [PATCH v3] drivers/edac/edac_mc: Remove all strcpy() uses
From: Robert Richter <rric@kernel.org>
Date: 2021-08-09 09:52:02
Also in:
linux-hardening, lkml
On 07.08.21 17:59:57, Len Baker wrote:
quoted hunk ↗ jump to hunk
@@ -1113,11 +1115,11 @@ void edac_mc_handle_error(const enum hw_event_mc_err_type type, p = e->label; *p = '\0'; } else { - if (p != e->label) { - strcpy(p, OTHER_LABEL); - p += strlen(OTHER_LABEL); - } - strcpy(p, dimm->label); + const char *text = (p != e->label) ? OTHER_LABEL : + dimm->label; + + strscpy(p, text, len); + len -= strlen(p);
The logic looks broken and dimm labels are not properly copied (the code should add an " or " separator between labels). -Robert
p += strlen(p); }