On Tue, Jul 13, 2021 at 03:27:01PM +0000, Luck, Tony wrote:

quoted

Instead of "open coding" DEVICE_ATTR, use the corresponding
helper macros DEVICE_ATTR_{RW,RO,WO} in amd64_edac.c

Some function names needed to be changed to match the device
conventions <foo>_show and <foo>_store, but the functionality
itself is unchanged.

The devices using EDAC_DCT_ATTR_SHOW() are left unchanged.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>

Yazen,

Boris is on vacation. Should I queue this change?

Hi Tony,

Yes, please.

Thanks,
Yazen