[PATCH] EDAC/igen6: fix core dependency

STALE1868d LANDED

Landed in mainline as 0a9ece9ba154 on 2021-06-20.

2 messages, 2 authors, 2021-06-20 · open the first message on its own page

[PATCH] EDAC/igen6: fix core dependency

From: Randy Dunlap <hidden>
Date: 2021-06-19 16:02:08

igen6_edac needs mce_register()/unregister() functions,
so it should depend on X86_MCE (or X86_MCE_INTEL).

That change prevents these build errors:

ld: drivers/edac/igen6_edac.o: in function `igen6_remove':
igen6_edac.c:(.text+0x494): undefined reference to `mce_unregister_decode_chain'
ld: drivers/edac/igen6_edac.o: in function `igen6_probe':
igen6_edac.c:(.text+0xf5b): undefined reference to `mce_register_decode_chain'

Fixes: 10590a9d4f23e ("EDAC/igen6: Add EDAC driver for Intel client SoCs using IBECC")
Signed-off-by: Randy Dunlap <redacted>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-edac@vger.kernel.org
---
 drivers/edac/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20210618.orig/drivers/edac/Kconfig
+++ linux-next-20210618/drivers/edac/Kconfig
@@ -270,7 +270,8 @@ config EDAC_PND2
 
 config EDAC_IGEN6
 	tristate "Intel client SoC Integrated MC"
-	depends on PCI && X86_64 && PCI_MMCONFIG && ARCH_HAVE_NMI_SAFE_CMPXCHG
+	depends on PCI && PCI_MMCONFIG && ARCH_HAVE_NMI_SAFE_CMPXCHG
+	depends on X64_64 && X86_MCE_INTEL
 	help
 	  Support for error detection and correction on the Intel
 	  client SoC Integrated Memory Controller using In-Band ECC IP.

RE: [PATCH] EDAC/igen6: fix core dependency

From: "Luck, Tony" <tony.luck@intel.com>
Date: 2021-06-20 21:08:26

igen6_edac needs mce_register()/unregister() functions,
so it should depend on X86_MCE (or X86_MCE_INTEL).
Thanks Randy

Also reported by the lkp robot (e-mail from the robot got to
me about six hours after your fix).

Applied.

-Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help