Thread (18 messages) 18 messages, 4 authors, 2021-03-11

Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64

From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-03-10 16:43:38
Also in: linux-arm-kernel, linux-clk, linux-devicetree, linux-fpga, lkml, netdev

On Wed, Mar 10, 2021 at 4:54 PM Krzysztof Kozlowski
[off-list ref] wrote:
On 10/03/2021 16:47, Krzysztof Kozlowski wrote:
quoted
This edac Altera driver is very weird... it uses the same compatible
differently depending whether this is 32-bit or 64-bit (e.g. Stratix
10)! On ARMv7 the compatible means for example one IRQ... On ARMv8, we
have two. It's quite a new code (2019 from Intel), not some ancient
legacy, so it should never have been accepted...
Oh, it's not that horrible as it sounds. They actually have different
compatibles for edac driver with these differences (e.g. in interrupts).
They just do not use them and instead check for the basic (common?)
compatible and architecture... Anyway without testing I am not the
person to fix the edac driver.
Ok, This should be fixed properly as you describe, but as a quick hack
it wouldn't be hard to just change the #ifdef to check for CONFIG_64BIT
instead of CONFIG_ARCH_STRATIX10 during the rename of the config
symbol.

       Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help