Thread (19 messages) 19 messages, 3 authors, 2021-02-24

Re: [PATCH v2] x86/mce: fix wrong no-return-ip logic in do_machine_check()

From: Aili Yao <hidden>
Date: 2021-02-22 11:22:51
Also in: lkml

On Mon, 22 Feb 2021 11:22:06 +0100
Borislav Petkov [off-list ref] wrote:
On Mon, Feb 22, 2021 at 06:08:19PM +0800, Aili Yao wrote:
quoted
So why would intel provide this MCG_STATUS_RIPV flag, it's better to
remove it as it will never be set, and all the related logic for this
flag is really needed ?  
Why would it never be set - of course it will be. You don't set it. If
you wanna inject errors, then make sure you inject *valid* errors which
the hardware *actually* generates, not some random ones.
As far as I know, Most of RAS related tests are faked, not real errors, and it's really meaningful.

You should better reproduce the issue I tried to fix, or at least read the code more detailly and you will
know if it's random and invalid

Best Regards!
Aili Yao
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help