Re: (sashiko review) [RFC PATCH v2 1/1] mm/damon: support MADV_COLLAPSE via DAMOS_COLLAPSE scheme action
From: SeongJae Park <sj@kernel.org>
Date: 2026-03-24 00:29:40
Also in:
damon, linux-mm, lkml
Forwarding Sashiko review for doing discussions via mails. # review url: https://sashiko.dev/#/patchset/20260323145646.4165053-2-gutierrez.asier@huawei-partners.com # start of sashiko.dev inline review commit eaed291e6fae91842b1836c68bab867d53525db5 Author: Asier Gutierrez [off-list ref] mm/damon: support MADV_COLLAPSE via DAMOS_COLLAPSE scheme action This commit introduces a new DAMON action, DAMOS_COLLAPSE. It allows DAMON to synchronously collapse an address range by calling madvise with MADV_COLLAPSE. Link: https://lore.kernel.org/damon/20260313000816.79933-1-sj@kernel.org/ (local) [ ... ]
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py index 3aa5c91548a5..c6476e63f4fb 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py@@ -123,11 +123,12 @@ def assert_scheme_committed(scheme, dump): 'pageout': 2, 'hugepage': 3, 'nohugeapge': 4, - 'lru_prio': 5, - 'lru_deprio': 6, - 'migrate_hot': 7, - 'migrate_cold': 8, - 'stat': 9, + 'collapse': 5 + 'lru_prio': 6,
Will this cause a Python syntax error when executing the selftest? It looks like there is a missing comma after 'collapse': 5, which might break the execution of the DAMON sysfs test suite. # end of sashiko.dev inline review # review url: https://sashiko.dev/#/patchset/20260323145646.4165053-2-gutierrez.asier@huawei-partners.com # # hkml [1] generated a draft of this mail. It can be regenerated # using below command: # # hkml patch sashiko_dev --for_forwarding \ # 20260323145646.4165053-2-gutierrez.asier@huawei-partners.com # # [1] https://github.com/sjp38/hackermail Sent using hkml (https://github.com/sjp38/hackermail)