RE: [PATCH v13 net-next 00/15] AccECN protocol case handling series

-----Original Message-----
From: Paolo Abeni <pabeni@redhat.com> 
Sent: Tuesday, February 3, 2026 1:51 PM
To: Chia-Yu Chang (Nokia) <redacted>; edumazet@google.com; parav@nvidia.com; linux-doc@vger.kernel.org; corbet@lwn.net; horms@kernel.org; dsahern@kernel.org; kuniyu@google.com; bpf@vger.kernel.org; netdev@vger.kernel.org; dave.taht@gmail.com; jhs@mojatatu.com; kuba@kernel.org; stephen@networkplumber.org; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; andrew+netdev@lunn.ch; donald.hunter@gmail.com; ast@fiberby.net; liuhangbin@gmail.com; shuah@kernel.org; linux-kselftest@vger.kernel.org; ij@kernel.org; ncardwell@google.com; Koen De Schepper (Nokia) <redacted>; g.white@cablelabs.com; ingemar.s.johansson@ericsson.com; mirja.kuehlewind@ericsson.com; cheshire@apple.com; rs.ietf@gmx.at; Jason_Livingood@comcast.com; vidhi_goel@apple.com
Subject: Re: [PATCH v13 net-next 00/15] AccECN protocol case handling series


CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



On 1/31/26 11:25 PM, chia-yu.chang@nokia-bell-labs.com wrote:

quoted

From: Chia-Yu Chang <redacted>

Hello,

Plesae find the v13 AccECN case handling patch series, which covers 
several excpetional case handling of Accurate ECN spec (RFC9768), adds 
new identifiers to be used by CC modules, adds ecn_delta into 
rate_sample, and keeps the ACE counter for computation, etc.

This patch series is part of the full AccECN patch series, which is at
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2FL4STeam%2Flinux-net-next%2Fcommits%2Fupstream_l4steam%2F&data
=05%7C02%7Cchia-yu.chang%40nokia-bell-labs.com%7C28d9664ae2ba4bc908b00
8de6322d99f%7C5d4717519675428d917b70f44f9630b0%7C0%7C0%7C6390571985045
13725%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAw
MCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdat
a=LE02CSf%2BwO3EhH844vnsvMN4ToH4FbvnmHNQH2GXKj4%3D&reserved=0

Beside the just shared feedback, the AI reported a bunch of other stuff that are not relevant:
- fixes tags, IMHO not needed since the touched features were just partially implemented before
- uapi breakage, already ruled out as irrelevant since the iproute bits are not there yet
- pktdrill syntax, which is a little inconsistent but AFAICS correct.

I'm not sure about the BIT() macro usage in uAPI, which is already a thing in many uAPI exposed headers, but does not look correct. I guess it could be handled with a follow-up, if needed.

So the only feedback the could really require a new revision is WRT ECN flags handling on retransmission - and I'm not 110% it needs a new
revision: please double check it.

Thanks,

Paolo

Hi Paolo,

Based on another email, if it is suggested to clarify that commit in the commit message then I can also include other listed issues.

And I would include fixes to packetdrill syntax and fixed to BIT() - which might have an issue if someone took only the header without BIT macro.

So, please let me know then I can submit v14 with all three changes, thanks.

Chia-Yu