Thread (32 messages) 32 messages, 4 authors, 2026-02-11

Re: [PATCH net-next V7 01/14] documentation: networking: add shared devlink documentation

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-05 02:02:58
Also in: linux-rdma, lkml, netdev

On Wed, 4 Feb 2026 08:12:00 +0100 Jiri Pirko wrote:
Wed, Feb 04, 2026 at 04:01:05AM +0100, kuba@kernel.org wrote:
quoted
On Tue, 3 Feb 2026 10:18:22 +0100 Jiri Pirko wrote:  
quoted
How exactly you can have a single devlink instance for multiple PFs of a
same device? I don't really understand how that could work, considering
dynamic binds/unbinds of the PFs within single host and/or multiple VMs
passing PFs to.  
The same way you currently gather up the devlink instances to create
the shared instance.  
What's the backing device / handle (busname/devname)? Best would be to
draw a picture, as always :)
Either the bus/dev that shows up first or we go back to index.
(My main point being that the single instance is strictly better
than shared, ie. no problem exists in single instance multi func
which does not exist in multi instance + extra instance multi func.
But some problems do exist in multi instance which do not in single
like the locking)
quoted
quoted
Okay. I originally wanted to use an id, similar to what we have in
the dpll. However I was forced by community to tie the instance to
bus/device. It is how it is, any idea how to relax this bond?  
Interesting! I was curious to research how we ended up here, found this:
https://lore.kernel.org/netdev/20160225225803.GA2191@nanopsycho.orion/ (local)
My reading is that Hannes was arguing against the _NAME attribute but
both _NAME and _INDEX were deleted? I think there's nothing wrong with
an index.  
He argues for "stable topology indentifiers", which randomly assigned
index is not.
Agreed, I love me a stable identifier myself! :) That does not mean 
we can't have ID _as well_ as the identifiers. Which lets us add
more stable identifiers and/or making some optional.

I think I was trying to sell you on "more stable identifiers" 
as a alternative to ALT_NAMEs for netdevs at some point ;)
Maybe I'm projecting that conversation onto what Hannes said.
quoted
FWIW using devlink day to day, the bus/device is not at all useful as
an identifier. Most of code touching devlink at Meta either matches
on devlink dev info or assumes there's one instance on the system.  
Okay, what's your suggestion going foreward then?
Add the ID back, make bus/dev optional, forgo the faux dev?
Would that work? Would exiting CLI become very unhappy? :S
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help