Re: [PATCH] docs: filesystems: add fs/open.c to api-summary

On 1/16/26 10:46 AM, Randy Dunlap wrote:

On 1/16/26 10:40 AM, Jonathan Corbet wrote:

quoted

Randy Dunlap [off-list ref] writes:

quoted

Include fs/open.c in filesystems/api-summary.rst to provide its
exported APIs.

Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org

 Documentation/filesystems/api-summary.rst |    3 +++
 1 file changed, 3 insertions(+)

--- linux-next-20251219.orig/Documentation/filesystems/api-summary.rst
+++ linux-next-20251219/Documentation/filesystems/api-summary.rst

@@ -56,6 +56,9 @@ Other Functions
 .. kernel-doc:: fs/namei.c
    :export:
 
+.. kernel-doc:: fs/open.c
+   :export:
+

So I've applied this, but it does add a couple of new warnings:

  Documentation/filesystems/api-summary:59: ./fs/open.c:1157: WARNING: Inline emphasis start-string without end-string. [docutils]
  Documentation/filesystems/api-summary:59: ./fs/open.c:1147: ERROR: Unknown target name: "o". [docutils]

It would be nice to get those fixed up.

Will do. Seems like I tweaked those already. I'll check.

thanks.

Seems I was confused with fs/namei.c, where I see similar warnings.
I don't see those warnings in fs/open.c.

I'm using today's linux-next tree, where the latest change to
fs/open.c is:
ommit 750d2f1f7b5c
Author: Al Viro [off-list ref]
Date:   Sun Dec 14 03:13:59 2025 -0500
    chroot(2): switch to CLASS(filename)

Do you have something later (newer) than that?

Also, at fs/open.c lines 1147-1157, I don't see anything that would
cause docs warnings.

Ideas?

thanks.
-- 
~Randy