Thread (60 messages) 60 messages, 4 authors, 2025-09-19

Re: [PATCH v2 05/16] iomap: propagate iomap_read_folio() error to caller

From: Christoph Hellwig <hch@infradead.org>
Date: 2025-09-11 11:13:11
Also in: gfs2, linux-block, linux-fsdevel, linux-xfs

On Mon, Sep 08, 2025 at 11:51:11AM -0700, Joanne Koong wrote:
Propagate any error encountered in iomap_read_folio() back up to its
caller (otherwise a default -EIO will be passed up by
filemap_read_folio() to callers). This is standard behavior for how
other filesystems handle their ->read_folio() errors as well.

Remove the out of date comment about setting the folio error flag.
Folio error flags were removed in commit 1f56eedf7ff7 ("iomap:
Remove calls to set and clear folio error flag").
As mentioned last time I actually think this is a bad idea, and the most
common helpers (mpage_read_folio and block_read_full_folio) will not
return and error here.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help