On Tue, Aug 26, 2025 at 10:03:40PM -0700, Randy Dunlap wrote:

quoted

+#include <linux/iommu.h>
+#include "../iommu-pages.h"
+#include <linux/export.h>

Could you put <linux/export.h> before <linux/iommu.h?
Does something prevent that?

Sure

quoted

+	/*
+	 * The aperture is limited to what the API can do after considering all
+	 * the different types dma_addr_t/unsigned long/pt_vaddr_t that are used
+	 * to store a VA. Set the aperture to something that is valid for all
+	 * cases. Saturate instead of truncate the end if the types are smaller
+	 * than the top range. aperture_end is a last.

Does "is a last" have something to do with terminating loop iteration?
Is it inclusive or exclusive?

It is intended to refer back to the definitions:

 *  start/end
 *     An half-open range, e.g. [0,0) refers to no VA.
 *  start/last
 *     An inclusive closed range, e.g. [0,0] refers to the VA 0

Where aperture_start/aperture_end doesn't follow that standard.

	 * cases. Saturate instead of truncate the end if the types are smaller
	 * than the top range. aperture_end should be called aperture_last.
	 */

Maybe?

quoted

+/**
+ * DOC: IOMMU Radix Page Table
+ *
+ * The iommu implementation of the Generic Page Table provides an ops struct

s/iommu/IOMMU/ in text (not functions/structs/etc.) where possible.

Sure

Got the rest, thanks

Jason