Thread (7 messages) 7 messages, 3 authors, 2025-07-21

Re: [PATCH v6 1/2] hwmon: (cros_ec) add PWM control over fans

From: Guenter Roeck <linux@roeck-us.net>
Date: 2025-07-19 04:45:32
Also in: chrome-platform, linux-hwmon, lkml

On Fri, Jul 18, 2025 at 03:08:29PM +0800, Sung-Chi Li wrote:
From: Sung-Chi Li <redacted>

Newer EC firmware supports controlling fans through host commands, so
adding corresponding implementations for controlling these fans in the
driver for other kernel services and userspace to control them.

The driver will first probe the supported host command versions (get and
set of fan PWM values, get and set of fan control mode) to see if the
connected EC fulfills the requirements of controlling the fan, then
exposes corresponding sysfs nodes for userspace to control the fan with
corresponding read and write implementations.
As EC will automatically change the fan mode to auto when the device is
suspended, the power management hooks are added as well to keep the fan
control mode and fan PWM value consistent during suspend and resume. As
we need to access the hwmon device in the power management hook, update
the driver by storing the hwmon device in the driver data as well.

Signed-off-by: Sung-Chi Li <redacted>
Acked-by: Thomas Weißschuh <linux@weissschuh.net>
+
...
+static int cros_ec_hwmon_read_pwm_enable(struct cros_ec_device *cros_ec, u8 index,
+					 u8 *control_method)
+{
+	struct ec_params_auto_fan_ctrl_v2 req = {
ec_params_auto_fan_ctrl_v2 isn't declared anywhere. Looks like some patch
is missing, and I don't immediately see it. Dropping the series.

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help